Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ability to edit/import gitconfig when no configmap exists #1204

Merged
merged 4 commits into from
Sep 30, 2024
Merged

feat: add ability to edit/import gitconfig when no configmap exists #1204

merged 4 commits into from
Sep 30, 2024

Conversation

akurinnoy
Copy link
Contributor

@akurinnoy akurinnoy commented Sep 26, 2024 •
edited
Loading

What does this PR do?

If it does not exist, the Dashboard creates a workspace-userdata-gitconfig-configmap Configmap with a data section like this

data:
  gitconfig: |
    [user]
    name=""
    email=""

This will allow users to edit this Git configuration, or import the entire .gitconfig file.

Screenshot/screencast of this PR

Screen.Recording.2024-09-26.at.13.10.06.mov

What issues does this PR fix or reference?

resolves eclipse-che/che#23147

Is it tested? How?

See screencast section

Release Notes

Docs PR

@akurinnoy
feat: add ability to edit/import gitconfig when no configmap exists
b2895ff 
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 26, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@che-bot
Copy link
Contributor

che-bot commented Sep 26, 2024

Click here to review and test in web IDE: Contribute

@codecov Codecov
Copy link

codecov bot commented Sep 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.49123% with 4 lines in your changes missing coverage. Please review.

Project coverage is 89.91%. Comparing base (d48136f) to head (1af744a).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
.../devworkspaceClient/services/gitConfigApi/index.ts 90.90% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1204      +/-   ##
==========================================
- Coverage   91.35%   89.91%   -1.45%     
==========================================
  Files         442      442              
  Lines       45650    45698      +48     
  Branches     3044     3060      +16     
==========================================
- Hits        41704    41088     -616     
- Misses       3946     4571     +625     
- Partials        0       39      +39

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1204

kubectl patch command 
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1204", name: che-dashboard}]}}]"

@akurinnoy akurinnoy self-assigned this Sep 26, 2024
@akurinnoy akurinnoy marked this pull request as ready for review September 26, 2024 11:55
akurinnoy and others added 2 commits September 26, 2024 16:10
@akurinnoy @olexii4
Update packages/dashboard-backend/src/devworkspaceClient/services/git…
5c946dc 
…ConfigApi/__tests__/index.spec.ts

Co-authored-by: Oleksii Orel <oorel@redhat.com>
@akurinnoy
fixup! Update packages/dashboard-backend/src/devworkspaceClient/servi…
1af744a 
…ces/gitConfigApi/__tests__/index.spec.ts
@github-actions GitHub Actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1204

kubectl patch command 
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1204", name: che-dashboard}]}}]"

@olexii4
Copy link
Contributor

olexii4 commented Sep 27, 2024

@akurinnoy Could you run yarn lint:fix and add a commit with changes for fixing the build?

olexii4
olexii4 approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@olexii4 olexii4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the lgtm label Sep 30, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 30, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@akurinnoy akurinnoy merged commit 45e8380 into main Sep 30, 2024
20 of 21 checks passed
@akurinnoy akurinnoy deleted the fix-empty-gitconfig branch September 30, 2024 14:02
@devstudio-release
Copy link

Build 3.17 :: dashboard_3.x/556: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.17 :: sync-to-downstream_3.x/7740: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.17 :: get-sources-rhpkg-container-build_3.x/7735: Console, Changes, Git Data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olexii4 olexii4 olexii4 approved these changes

@ibuziuk ibuziuk Awaiting requested review from ibuziuk ibuziuk is a code owner

Assignees

@olexii4 olexii4

@akurinnoy akurinnoy

Labels
lgtm
Projects
None yet
Milestone
No milestone
4 participants
@akurinnoy @che-bot @olexii4 @devstudio-release